Mirror/FairMQ
1
0
Fork 0
mirror of https://github.com/FairRootGroup/FairMQ.git synced 2025-10-15 09:31:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Improve ChangeState API

Browse Source 
* Add `[[nodiscard]]` to `bool Device::ChangeState()`
* Introduce throwing variant `void Device::ChangeStateOrThrow()`

resolves #441
This commit is contained in:
Dennis Klein
2023-02-28 12:12:54 +01:00
parent 919c496c42
commit 035029df6a
4 changed files with 75 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test/device/_transitions.cxx
View File

@@ -97,4 +97,26 @@ TEST(Transitions, ConcurrentTransitionTos)
}
}
TEST(Transitions, InvalidChangeState)
{
Device device;
thread t([&] { device.RunStateMachine(); });
ASSERT_FALSE(device.ChangeState(Transition::Connect));
ASSERT_TRUE(device.ChangeState(Transition::End));
if (t.joinable()) { t.join(); }
}
TEST(Transitions, InvalidChangeStateOrThrow)
{
Device device;
thread t([&] { device.RunStateMachine(); });
ASSERT_THROW(device.ChangeStateOrThrow(Transition::Connect), std::system_error);
ASSERT_NO_THROW(device.ChangeStateOrThrow(Transition::End));
if (t.joinable()) { t.join(); }
}
} // namespace