Mirror/FairMQ
1
0
Fork 0
mirror of https://github.com/FairRootGroup/FairMQ.git synced 2025-10-12 16:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded if when deleting NULL / 0 / nullptr

Browse Source 
C++ standard dictates that NULL / 0 / nullptr is a valid argument for
delete which then simply has no effect:

"The value of the first argument supplied to a deallocation function may
be a null pointer value; if so, and if the deallocation function is one
supplied in the standard library, the call has no effect."

I therefore think in these particular case it's safe to remove the ifs.
This commit is contained in:
Giulio Eulisse 2017-03-13 11:50:17 +01:00 committed by Mohammad Al-Turany
parent d1cf852c98
commit 2a72d58766
3 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fairmq/nanomsg/FairMQPollerNN.cxx
View File

@ -230,9 +230,6 @@ bool FairMQPollerNN::CheckOutput(const string channelKey, const int index)
}
FairMQPollerNN::~FairMQPollerNN()
{
if (items != NULL)
{
delete[] items;
}
}

3
fairmq/shmem/FairMQPollerSHM.cxx
View File

@ -233,9 +233,6 @@ bool FairMQPollerSHM::CheckOutput(const string channelKey, const int index)
}
FairMQPollerSHM::~FairMQPollerSHM()
{
if (items != NULL)
{
delete[] items;
}
}

3
fairmq/zeromq/FairMQPollerZMQ.cxx
View File

@ -233,9 +233,6 @@ bool FairMQPollerZMQ::CheckOutput(const string channelKey, const int index)
}
FairMQPollerZMQ::~FairMQPollerZMQ()
{
if (items != NULL)
{
delete[] items;
}
}