Apply modernize-use-equals-default

examples/1-1/sampler.cxx

@@ -16,7 +16,7 @@ namespace bpo = boost::program_options;
 class Sampler : public FairMQDevice
 {
   public:
-    Sampler() {}
+    Sampler() = default;
 
   protected:
     std::string fText;

examples/1-n-1/sampler.cxx

@@ -18,7 +18,7 @@ namespace bpo = boost::program_options;
 class Sampler : public FairMQDevice
 {
   public:
-    Sampler() {}
+    Sampler() = default;
 
   protected:
     std::string fText;

examples/copypush/sampler.cxx

@@ -18,7 +18,7 @@ namespace bpo = boost::program_options;
 class Sampler : public FairMQDevice
 {
   public:
-    Sampler() {}
+    Sampler() = default;
 
   protected:
     void InitTask() override

examples/dds/sampler.cxx

@@ -16,8 +16,7 @@ namespace bpo = boost::program_options;
 class Sampler : public FairMQDevice
 {
   public:
-    Sampler()
+    Sampler() = default;
-    {}
 
     void InitTask() override
     {

examples/multipart/sampler.cxx

@@ -20,7 +20,7 @@ namespace bpo = boost::program_options;
 class Sampler : public FairMQDevice
 {
   public:
-    Sampler() {}
+    Sampler() = default;
 
   protected:
     void InitTask() override

examples/multiple-channels/broadcaster.cxx

@@ -17,7 +17,7 @@ namespace bpo = boost::program_options;
 class Broadcaster : public FairMQDevice
 {
   public:
-    Broadcaster() {}
+    Broadcaster() = default;
 
   protected:
     bool ConditionalRun() override

examples/multiple-channels/sampler.cxx

@@ -19,7 +19,7 @@ namespace bpo = boost::program_options;
 class Sampler : public FairMQDevice
 {
   public:
-    Sampler() {}
+    Sampler() = default;
 
     void InitTask() override
     {

examples/multiple-transports/sampler1.cxx

@@ -16,7 +16,7 @@ namespace bpo = boost::program_options;
 class Sampler1 : public FairMQDevice
 {
   public:
-    Sampler1() {}
+    Sampler1() = default;
 
   protected:
     void InitTask() override

examples/multiple-transports/sampler2.cxx

@@ -16,7 +16,7 @@ namespace bpo = boost::program_options;
 class Sampler2 : public FairMQDevice
 {
   public:
-    Sampler2() {}
+    Sampler2() = default;
 
   protected:
     void InitTask() override

examples/n-m/sender.cxx

@@ -20,7 +20,7 @@ namespace bpo = boost::program_options;
 class Sender : public FairMQDevice
 {
   public:
-    Sender() {}
+    Sender() = default;
 
     void InitTask() override
     {

examples/n-m/synchronizer.cxx

@@ -18,7 +18,7 @@ namespace bpo = boost::program_options;
 class Synchronizer : public FairMQDevice
 {
   public:
-    Synchronizer() {}
+    Synchronizer() = default;
 
     bool ConditionalRun() override
     {

examples/qc/sampler.cxx

@@ -15,7 +15,7 @@
 class Sampler : public FairMQDevice
 {
   public:
-    Sampler() {}
+    Sampler() = default;
 
   protected:
     virtual bool ConditionalRun()

examples/readout/builder.cxx

@@ -16,7 +16,7 @@ namespace bpo = boost::program_options;
 class Builder : public FairMQDevice
 {
   public:
-    Builder() {}
+    Builder() = default;
 
     void Init() override
     {

examples/readout/processor.cxx

@@ -14,7 +14,8 @@ namespace bpo = boost::program_options;
 class Processor : public FairMQDevice
 {
   public:
-    Processor() {
+    Processor()
+    {
         OnData("bp", &Processor::HandleData);
     }
 

examples/readout/readout.cxx

@@ -18,7 +18,7 @@ namespace bpo = boost::program_options;
 class Readout : public FairMQDevice
 {
   public:
-    Readout() {}
+    Readout() = default;
 
     void InitTask() override
     {

examples/readout/receiver.cxx

@@ -14,7 +14,7 @@ namespace bpo = boost::program_options;
 class Receiver : public FairMQDevice
 {
   public:
-    Receiver() {}
+    Receiver() = default;
 
     void InitTask() override
     {

examples/readout/sender.cxx

@@ -16,7 +16,7 @@ namespace bpo = boost::program_options;
 class Sender : public FairMQDevice
 {
   public:
-    Sender() {}
+    Sender() = default;
 
     void Init() override
     {

examples/region/sampler.cxx

@@ -18,7 +18,7 @@ namespace bpo = boost::program_options;
 class Sampler : public FairMQDevice
 {
   public:
-    Sampler() {}
+    Sampler() = default;
 
     void InitTask() override
     {

examples/region/sink.cxx

@@ -14,7 +14,7 @@ namespace bpo = boost::program_options;
 class Sink : public FairMQDevice
 {
   public:
-    Sink() {}
+    Sink() = default;
 
     void InitTask() override
     {

examples/req-rep/client.cxx

@@ -18,7 +18,7 @@ namespace bpo = boost::program_options;
 class Client : public FairMQDevice
 {
   public:
-    Client() {}
+    Client() = default;
 
     void InitTask() override
     {

fairmq/FairMQChannel.h

@@ -81,7 +81,8 @@ class FairMQChannel
     // FairMQChannel& operator=(FairMQChannel&&) = delete;
 
     /// Destructor
-    virtual ~FairMQChannel() { /* LOG(warn) << "Destroying channel '" << fName << "'"; */ }
+    virtual ~FairMQChannel() = default;
+    // { LOG(warn) << "Destroying channel '" << fName << "'"; }
 
     struct ChannelConfigurationError : std::runtime_error { using std::runtime_error::runtime_error; };
 

fairmq/FairMQMessage.h

@@ -52,7 +52,7 @@ class FairMQMessage
 
     virtual void Copy(const FairMQMessage& msg) = 0;
 
-    virtual ~FairMQMessage() {};
+    virtual ~FairMQMessage() = default;
 
   private:
     FairMQTransportFactory* fTransport{nullptr};

fairmq/FairMQParts.h

@@ -24,7 +24,7 @@ class FairMQParts
 
   public:
     /// Default constructor
-    FairMQParts() {};
+    FairMQParts() = default;
     /// Copy Constructor
     FairMQParts(const FairMQParts&) = delete;
     /// Move constructor
@@ -35,7 +35,7 @@ class FairMQParts
     template <typename... Ts>
     FairMQParts(Ts&&... messages) { AddPart(std::forward<Ts>(messages)...); }
     /// Default destructor
-    ~FairMQParts() {};
+    ~FairMQParts() = default;
 
     /// Adds part (FairMQMessage) to the container
     /// @param msg message pointer (for example created with NewMessage() method of FairMQDevice)

fairmq/FairMQPoller.h

@@ -22,7 +22,7 @@ class FairMQPoller
     virtual bool CheckInput(const std::string& channelKey, const int index) = 0;
     virtual bool CheckOutput(const std::string& channelKey, const int index) = 0;
 
-    virtual ~FairMQPoller() {};
+    virtual ~FairMQPoller() = default;
 };
 
 using FairMQPollerPtr = std::unique_ptr<FairMQPoller>;

fairmq/FairMQSocket.h

@@ -35,7 +35,7 @@ enum class TransferCode : int
 class FairMQSocket
 {
   public:
-    FairMQSocket() {}
+    FairMQSocket() = default;
     FairMQSocket(FairMQTransportFactory* fac) : fTransport(fac) {}
 
     virtual std::string GetId() const = 0;
@@ -76,7 +76,7 @@ class FairMQSocket
     FairMQTransportFactory* GetTransport() { return fTransport; }
     void SetTransport(FairMQTransportFactory* transport) { fTransport = transport; }
 
-    virtual ~FairMQSocket() {};
+    virtual ~FairMQSocket() = default;
 
   private:
     FairMQTransportFactory* fTransport{nullptr};

fairmq/FairMQTransportFactory.h

@@ -122,7 +122,7 @@ class FairMQTransportFactory
     virtual void Resume() = 0;
     virtual void Reset() = 0;
 
-    virtual ~FairMQTransportFactory() {};
+    virtual ~FairMQTransportFactory() = default;
 
     static auto CreateTransportFactory(const std::string& type, const std::string& id = "", const fair::mq::ProgOptions* config = nullptr) -> std::shared_ptr<FairMQTransportFactory>;
 

fairmq/FairMQUnmanagedRegion.h

@@ -27,7 +27,7 @@ enum class FairMQRegionEvent : int
 
 struct FairMQRegionInfo
 {
-    FairMQRegionInfo() {}
+    FairMQRegionInfo() = default;
 
     FairMQRegionInfo(bool _managed, uint64_t _id, void* _ptr, size_t _size, int64_t _flags, FairMQRegionEvent _event)
         : managed(_managed)
@@ -63,7 +63,7 @@ using FairMQRegionEventCallback = std::function<void(FairMQRegionInfo)>;
 class FairMQUnmanagedRegion
 {
   public:
-    FairMQUnmanagedRegion() {}
+    FairMQUnmanagedRegion() = default;
     FairMQUnmanagedRegion(FairMQTransportFactory* factory) : fTransport(factory) {}
 
     virtual void* GetData() const = 0;
@@ -76,7 +76,7 @@ class FairMQUnmanagedRegion
     FairMQTransportFactory* GetTransport() { return fTransport; }
     void SetTransport(FairMQTransportFactory* transport) { fTransport = transport; }
 
-    virtual ~FairMQUnmanagedRegion() {};
+    virtual ~FairMQUnmanagedRegion() = default;
 
   private:
     FairMQTransportFactory* fTransport{nullptr};
@@ -103,7 +103,7 @@ namespace fair::mq
 
 struct RegionConfig
 {
-    RegionConfig() {}
+    RegionConfig() = default;
 
     RegionConfig(bool l, bool z)
         : lock(l), zero(z)

fairmq/ProgOptions.h

@@ -35,7 +35,7 @@ class ProgOptions
 {
   public:
     ProgOptions();
-    virtual ~ProgOptions() {}
+    virtual ~ProgOptions() = default;
 
     void ParseAll(const std::vector<std::string>& cmdArgs, bool allowUnregistered);
     void ParseAll(const int argc, char const* const* argv, bool allowUnregistered = true);

fairmq/StateMachine.cxx

@@ -84,7 +84,7 @@ struct Machine_ : public state_machine_def<Machine_>
         , fNewStatePending(false)
     {}
 
-    virtual ~Machine_() {}
+    virtual ~Machine_() = default;
 
     // initial states
     using initial_state = bmpl::vector<IDLE_S, OK_S>;

fairmq/StateQueue.h

@@ -23,8 +23,8 @@ namespace fair::mq
 class StateQueue
 {
   public:
-    StateQueue() {}
+    StateQueue() = default;
-    ~StateQueue() {}
+    ~StateQueue() = default;
 
     fair::mq::State WaitForNext()
     {

fairmq/devices/BenchmarkSampler.h

@@ -29,7 +29,7 @@ namespace fair::mq
 class BenchmarkSampler : public Device
 {
   public:
-    BenchmarkSampler() {}
+    BenchmarkSampler() = default;
 
     void InitTask() override
     {

fairmq/devices/Multiplier.h

@@ -20,7 +20,7 @@ namespace fair::mq
 class Multiplier : public Device
 {
   public:
-    Multiplier() {}
+    Multiplier() = default;
 
   protected:
     bool fMultipart = true;

fairmq/devices/Proxy.h

@@ -19,7 +19,7 @@ namespace fair::mq
 class Proxy : public Device
 {
   public:
-    Proxy() {}
+    Proxy() = default;
 
   protected:
     bool fMultipart = true;

fairmq/devices/Sink.h

@@ -25,7 +25,7 @@ namespace fair::mq
 class Sink : public Device
 {
   public:
-    Sink() {}
+    Sink() = default;
 
   protected:
     bool fMultipart = false;

fairmq/devices/Splitter.h

@@ -19,7 +19,7 @@ namespace fair::mq
 class Splitter : public Device
 {
   public:
-    Splitter() {}
+    Splitter() = default;
 
   protected:
     bool fMultipart = true;

fairmq/sdk/commands/Commands.h

@@ -355,7 +355,7 @@ struct Cmds
     using container = std::vector<std::unique_ptr<Cmd>>;
     struct CommandFormatError : std::runtime_error { using std::runtime_error::runtime_error; };
 
-    explicit Cmds() {}
+    explicit Cmds() = default;
 
     template<typename... Rest>
     explicit Cmds(std::unique_ptr<Cmd>&& first, Rest&&... rest)

fairmq/shmem/Common.h

@@ -187,7 +187,7 @@ using Uint16MsgDebugMapHashMap = boost::unordered_map<uint16_t, SizetMsgDebugMap
 
 struct RegionBlock
 {
-    RegionBlock() {}
+    RegionBlock() = default;
 
     RegionBlock(boost::interprocess::managed_shared_memory::handle_t handle, size_t size, size_t hint)
         : fHandle(handle)

test/device/_config.cxx

@@ -91,8 +91,7 @@ class TestDevice : public FairMQDevice
 class Config : public ::testing::Test
 {
   public:
-    Config()
+    Config() = default;
-    {}
 
     string TestDeviceSetConfig(const string& transport)
     {

test/device/_transitions.cxx

@@ -23,7 +23,7 @@ using namespace fair::mq;
 class SlowDevice : public FairMQDevice
 {
   public:
-    SlowDevice() {}
+    SlowDevice() = default;
 
   protected:
     void Init()

test/plugin_services/_config.cxx

@@ -13,10 +13,10 @@
 
 struct MyClass
 {
-    MyClass() {}
+    MyClass() = default;
     MyClass(const std::string& a) : msg(a) {}
     MyClass(const MyClass&) = default;
-    MyClass& operator=(const MyClass& b) { msg = b.msg; return *this; };
+    MyClass& operator=(const MyClass& b) = default;
     std::string msg;
 };