Mirror/FairMQ
1
0
Fork 0
mirror of https://github.com/FairRootGroup/FairMQ.git synced 2025-10-13 16:46:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tidy): Only emit diagnostic if source location is valid

Browse Source
This commit is contained in:
Dennis Klein 2022-05-18 07:11:07 +02:00
parent c3fdc8c08c
commit 9297308f8a
1 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
fairmq/tidy/ModernizeNonNamespacedTypes.h
View File

@ -14,7 +14,6 @@
#include <clang/ASTMatchers/ASTMatchers.h> #include <clang/ASTMatchers/ASTMatchers.h>
#include <clang/Basic/Diagnostic.h> #include <clang/Basic/Diagnostic.h>
#include <llvm/Support/Casting.h> #include <llvm/Support/Casting.h>
#include <sstream>
namespace fair::mq::tidy { namespace fair::mq::tidy {
@ -44,29 +43,22 @@ struct ModernizeNonNamespacedTypes
if (auto const type_alias_decl = m.Nodes.getNodeAs<TypeAliasDecl>("decl")) { if (auto const type_alias_decl = m.Nodes.getNodeAs<TypeAliasDecl>("decl")) {
auto const underlying_type(type_alias_decl->getUnderlyingType()); auto const underlying_type(type_alias_decl->getUnderlyingType());
// auto ldecl_ctx(type_loc->getType()getLexicalDeclContext());
// std::stringstream s;
// while (ldecl_ctx) {
// s << "." << ldecl_ctx->getDeclKindName();
// if (ldecl_ctx->isNamespace()) {
// s << dyn_cast<NamespaceDecl>(ldecl_ctx)->getNameAsString();
// }
// ldecl_ctx = ldecl_ctx->getLexicalParent();
// }
if (underlying_type.getAsString().rfind("fair::mq::", 0) == 0) { if (underlying_type.getAsString().rfind("fair::mq::", 0) == 0) {
auto& diag_engine(m.Context->getDiagnostics()); auto& diag_engine(m.Context->getDiagnostics());
auto builder( auto const location(type_loc->getBeginLoc());
diag_engine.Report(type_loc->getBeginLoc(), if (location.isValid()) {
diag_engine.getCustomDiagID( auto builder(diag_engine.Report(
DiagnosticsEngine::Warning, location,
"Modernize non-namespaced type %0 with %1. [%2]"))); diag_engine.getCustomDiagID(
builder << named_decl; DiagnosticsEngine::Warning,
builder << underlying_type; "Modernize non-namespaced type %0 with %1. [%2]")));
builder << "fairmq-modernize-nonnamespaced-types"; builder << named_decl;
builder << underlying_type;
builder << "fairmq-modernize-nonnamespaced-types";
builder.AddFixItHint(FixItHint::CreateReplacement( builder.AddFixItHint(FixItHint::CreateReplacement(
type_loc->getSourceRange(), underlying_type.getAsString())); type_loc->getSourceRange(), underlying_type.getAsString()));
}
} }
} }
} }