diff --git a/fairmq/logger/CMakeLists.txt b/fairmq/logger/CMakeLists.txt index 49afa086..147c3966 100644 --- a/fairmq/logger/CMakeLists.txt +++ b/fairmq/logger/CMakeLists.txt @@ -36,7 +36,7 @@ set(DEPENDENCIES pthread ) -install(FILES logger.h logger_def.h DESTINATION include/logger) +install(FILES logger.h logger_def.h fairroot_null_deleter.h DESTINATION include/logger) GENERATE_LIBRARY() diff --git a/fairmq/logger/logger.cxx b/fairmq/logger/logger.cxx index 2c4ada89..2efc400f 100644 --- a/fairmq/logger/logger.cxx +++ b/fairmq/logger/logger.cxx @@ -9,16 +9,13 @@ #include #include -#include -#include #include -#include #include -#include -#include #include +#include #include #include + #include #include diff --git a/fairmq/logger/logger.h b/fairmq/logger/logger.h index 0f3f311d..3bf9f851 100644 --- a/fairmq/logger/logger.h +++ b/fairmq/logger/logger.h @@ -21,19 +21,51 @@ #include #include + +#include +#include + + + + +// WARNING : pragma commands to hide boost Wshadow warning +#if defined(__clang__) + _Pragma("clang diagnostic push") + _Pragma("clang diagnostic ignored \"-Wshadow\"") // boost #include #include -#include #include #include #include -#include #include - +#include +#include +#include // fairmq #include "logger_def.h" - + _Pragma("clang diagnostic pop") +#elif defined(__GNUC__) || defined(__GNUG__) + _Pragma("GCC diagnostic push") + _Pragma("GCC diagnostic ignored \"-Wshadow\"") +// boost +#include +#include +#include +#include +#include +#include +#include +#include +#include +// fairmq +#include "logger_def.h" + _Pragma("GCC diagnostic pop") +#endif + + + + // Note : the following types and values must be defined in the included logger_def.h : // 1- custom_severity_level // 2- SEVERITY_THRESHOLD diff --git a/fairmq/logger/logger_oldboost_version.cxx b/fairmq/logger/logger_oldboost_version.cxx index 72b04454..706af40d 100644 --- a/fairmq/logger/logger_oldboost_version.cxx +++ b/fairmq/logger/logger_oldboost_version.cxx @@ -10,23 +10,19 @@ * copied verbatim in the file "LICENSE" * ********************************************************************************/ #include "logger.h" +#include "fairroot_null_deleter.h" #include #include -#include -#include #include -#include #include - -#include #include #include #include + #include #include -#include "fairroot_null_deleter.h" namespace logging = boost::log; namespace src = boost::log::sources; diff --git a/fairmq/logger/run/testLogger.cxx b/fairmq/logger/run/testLogger.cxx index 94016b5f..ba3f187d 100644 --- a/fairmq/logger/run/testLogger.cxx +++ b/fairmq/logger/run/testLogger.cxx @@ -6,8 +6,21 @@ * copied verbatim in the file "LICENSE" * ********************************************************************************/ -#include "logger.h" +// WARNING : pragma commands to hide boost warning +// TODO : remove these pragma commands when boost will fix this issue in future release +#if defined(__clang__) + _Pragma("clang diagnostic push") + _Pragma("clang diagnostic ignored \"-Wshadow\"") + #include "logger.h" + _Pragma("clang diagnostic pop") +#elif defined(__GNUC__) || defined(__GNUG__) + _Pragma("GCC diagnostic push") + _Pragma("GCC diagnostic ignored \"-Wshadow\"") + #include "logger.h" + _Pragma("GCC diagnostic pop") +#endif + void test_logger() { LOG(TRACE) << "this is a trace message"; diff --git a/fairmq/options/FairMQParser.cxx b/fairmq/options/FairMQParser.cxx index 997895c2..65f02f52 100644 --- a/fairmq/options/FairMQParser.cxx +++ b/fairmq/options/FairMQParser.cxx @@ -15,12 +15,24 @@ #include "FairMQParser.h" #include "FairMQLogger.h" #include + // WARNING : pragma commands to hide boost (1.54.0) warning // TODO : remove these pragma commands when boost will fix this issue in future release -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wshadow" -#include -#pragma clang diagnostic pop +#if defined(__clang__) + _Pragma("clang diagnostic push") + _Pragma("clang diagnostic ignored \"-Wshadow\"") + #include + _Pragma("clang diagnostic pop") +#elif defined(__GNUC__) || defined(__GNUG__) + _Pragma("GCC diagnostic push") + _Pragma("GCC diagnostic ignored \"-Wshadow\"") + #include + _Pragma("GCC diagnostic pop") +#endif + + + + namespace FairMQParser {