From b53d25738e952151827fd0653731e14e36be2ff0 Mon Sep 17 00:00:00 2001 From: Dennis Klein Date: Tue, 9 Jun 2026 17:37:00 +0200 Subject: [PATCH] build: curate clang-tidy to an enforceable check set - drop the broad `cppcoreguidelines-*` glob: it produced ~4500 findings (magic numbers, non-private members, owning-memory, pointer arithmetic, ...) that are aspirational and out of scope for the warning gate - drop modernize-use-equals-default: in this codebase it only yields false/unsafe positives, e.g. `= default` on a constructor that explicitly initializes atomic members (which default-init leaves indeterminate in C++17), and invalid output on constructors with a member-init list - drop modernize-pass-by-value: it rewrites constructor parameters to by-value + std::move, changing public constructor signatures, which is an ABI-relevant change unsuitable for a library's public headers - keep the deliberately-listed modernize/readability/performance checks --- .clang-tidy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 1d203333..dd5e4f84 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,3 +1,3 @@ --- -Checks: 'cppcoreguidelines-*,misc-unused-alias-decls,misc-unused-parameters,modernize-pass-by-value,modernize-deprecated-headers,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-use-bool-literals,modernize-use-default-member-init,modernize-use-emplace,modernize-use-equals-default,modernize-use-equals-delete,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-using,performance-faster-string-find,performance-for-range-copy,performance-unnecessary-copy-initialization,readability-avoid-const-params-in-decls,readability-braces-around-statements,readability-container-size-empty,readability-delete-null-pointer,readability-redundant-member-init,readability-redundant-string-init,readability-static-accessed-through-instance,readability-string-compare' +Checks: 'misc-unused-alias-decls,misc-unused-parameters,modernize-deprecated-headers,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-use-bool-literals,modernize-use-default-member-init,modernize-use-emplace,modernize-use-equals-delete,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-using,performance-faster-string-find,performance-for-range-copy,performance-unnecessary-copy-initialization,readability-avoid-const-params-in-decls,readability-braces-around-statements,readability-container-size-empty,readability-delete-null-pointer,readability-redundant-member-init,readability-redundant-string-init,readability-static-accessed-through-instance,readability-string-compare' HeaderFilterRegex: '/(fairmq/)'