From c34d1f09465c57625c826dc90e9a3b0ec7334b99 Mon Sep 17 00:00:00 2001 From: Alexey Rybalchenko Date: Wed, 23 Oct 2019 11:53:51 +0200 Subject: [PATCH] Cleanup includes --- examples/1-1/Sampler.cxx | 3 --- fairmq/EventManager.h | 4 +--- fairmq/FairMQChannel.cxx | 3 ++- fairmq/FairMQChannel.h | 6 +++--- fairmq/FairMQDevice.cxx | 6 +++--- fairmq/FairMQDevice.h | 13 +++++-------- fairmq/FairMQTransportFactory.cxx | 3 +-- fairmq/FairMQTransportFactory.h | 4 +++- fairmq/MemoryResources.h | 4 ---- fairmq/Plugin.h | 3 ++- fairmq/PluginManager.cxx | 2 +- fairmq/PluginManager.h | 8 +++++--- fairmq/PluginServices.cxx | 1 + fairmq/PluginServices.h | 1 - fairmq/ProgOptions.cxx | 2 +- fairmq/ProgOptions.h | 2 +- fairmq/Transports.h | 2 +- fairmq/devices/FairMQBenchmarkSampler.cxx | 7 +------ fairmq/devices/FairMQBenchmarkSampler.h | 6 ++++-- fairmq/plugins/DDS/DDS.cxx | 11 ++++------- fairmq/plugins/DDS/DDS.h | 22 ++++++++++++---------- fairmq/plugins/DDS/runDDSCommandUI.cxx | 9 +-------- fairmq/sdk/Error.h | 2 +- fairmq/sdk/Topology.h | 2 +- fairmq/sdk/commands/Commands.h | 2 +- fairmq/shmem/Manager.cxx | 2 ++ fairmq/shmem/Manager.h | 1 - fairmq/shmem/Region.cxx | 2 ++ fairmq/shmem/Region.h | 1 - fairmq/tools/Strings.h | 14 ++++---------- test/sdk/Fixtures.h | 2 +- 31 files changed, 64 insertions(+), 86 deletions(-) diff --git a/examples/1-1/Sampler.cxx b/examples/1-1/Sampler.cxx index 4d3c66c6..36f52986 100644 --- a/examples/1-1/Sampler.cxx +++ b/examples/1-1/Sampler.cxx @@ -6,9 +6,6 @@ * copied verbatim in the file "LICENSE" * ********************************************************************************/ -#include // this_thread::sleep_for -#include - #include "Sampler.h" using namespace std; diff --git a/fairmq/EventManager.h b/fairmq/EventManager.h index 43f3f267..d4b3380f 100644 --- a/fairmq/EventManager.h +++ b/fairmq/EventManager.h @@ -12,12 +12,10 @@ #include #include #include -#include #include -#include #include #include -#include +#include #include #include diff --git a/fairmq/FairMQChannel.cxx b/fairmq/FairMQChannel.cxx index 52e3687f..08585e83 100644 --- a/fairmq/FairMQChannel.cxx +++ b/fairmq/FairMQChannel.cxx @@ -7,7 +7,8 @@ ********************************************************************************/ #include "FairMQChannel.h" -#include +#include +#include #include // join/split diff --git a/fairmq/FairMQChannel.h b/fairmq/FairMQChannel.h index ece7940d..8e7a927e 100644 --- a/fairmq/FairMQChannel.h +++ b/fairmq/FairMQChannel.h @@ -10,6 +10,7 @@ #define FAIRMQCHANNEL_H_ #include +#include #include #include #include @@ -17,15 +18,14 @@ #include #include -#include - #include #include // unique_ptr, shared_ptr #include -#include #include #include #include // std::move +#include // size_t +#include // int64_t class FairMQChannel { diff --git a/fairmq/FairMQDevice.cxx b/fairmq/FairMQDevice.cxx index 4906153a..4e79f8c8 100644 --- a/fairmq/FairMQDevice.cxx +++ b/fairmq/FairMQDevice.cxx @@ -8,15 +8,15 @@ #include +#include +#include + #include // join/split #include -#include #include #include #include -#include -#include #include #include #include // std::max diff --git a/fairmq/FairMQDevice.h b/fairmq/FairMQDevice.h index 0d82e9ef..8e8abb87 100644 --- a/fairmq/FairMQDevice.h +++ b/fairmq/FairMQDevice.h @@ -14,7 +14,6 @@ #include #include -#include #include #include #include @@ -24,21 +23,19 @@ #include #include // unique_ptr -#include // std::sort() +#include // find #include #include #include #include #include -#include // static_assert -#include // is_trivially_copyable #include -#include - #include -#include +#include +#include +#include // pair -#include +#include using FairMQChannelMap = std::unordered_map>; diff --git a/fairmq/FairMQTransportFactory.cxx b/fairmq/FairMQTransportFactory.cxx index b9bc1bfc..8c7ef5eb 100644 --- a/fairmq/FairMQTransportFactory.cxx +++ b/fairmq/FairMQTransportFactory.cxx @@ -16,11 +16,10 @@ #include #endif #include -#include +#include #include #include -#include FairMQTransportFactory::FairMQTransportFactory(const std::string& id) : fkId(id) diff --git a/fairmq/FairMQTransportFactory.h b/fairmq/FairMQTransportFactory.h index 143b1e31..3c982c17 100644 --- a/fairmq/FairMQTransportFactory.h +++ b/fairmq/FairMQTransportFactory.h @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -22,8 +21,11 @@ #include #include #include +#include +#include // size_t class FairMQChannel; +namespace fair { namespace mq { class ProgOptions; } } class FairMQTransportFactory { diff --git a/fairmq/MemoryResources.h b/fairmq/MemoryResources.h index 9a4c93c7..93f8277a 100644 --- a/fairmq/MemoryResources.h +++ b/fairmq/MemoryResources.h @@ -23,11 +23,7 @@ class FairMQTransportFactory; #include #include #include -#include -#include -#include #include -#include namespace fair { namespace mq { diff --git a/fairmq/Plugin.h b/fairmq/Plugin.h index c76e2be1..e9954384 100644 --- a/fairmq/Plugin.h +++ b/fairmq/Plugin.h @@ -9,7 +9,8 @@ #ifndef FAIR_MQ_PLUGIN_H #define FAIR_MQ_PLUGIN_H -#include +#include +#include #include #include diff --git a/fairmq/PluginManager.cxx b/fairmq/PluginManager.cxx index 1c54ee06..b1ffc0cf 100644 --- a/fairmq/PluginManager.cxx +++ b/fairmq/PluginManager.cxx @@ -8,7 +8,7 @@ #include #include -#include +#include #include #include #include diff --git a/fairmq/PluginManager.h b/fairmq/PluginManager.h index 3a81699b..2e409bda 100644 --- a/fairmq/PluginManager.h +++ b/fairmq/PluginManager.h @@ -11,8 +11,9 @@ #include #include -#include -#include +#include +#include + #define BOOST_FILESYSTEM_VERSION 3 #define BOOST_FILESYSTEM_NO_DEPRECATED #include @@ -21,13 +22,14 @@ #include #include #include + #include #include #include #include #include -#include #include +#include // forward namespace fair { diff --git a/fairmq/PluginServices.cxx b/fairmq/PluginServices.cxx index 283048e7..17deaa4f 100644 --- a/fairmq/PluginServices.cxx +++ b/fairmq/PluginServices.cxx @@ -7,6 +7,7 @@ ********************************************************************************/ #include +#include using namespace fair::mq; using namespace std; diff --git a/fairmq/PluginServices.h b/fairmq/PluginServices.h index 7eb565ad..142b346d 100644 --- a/fairmq/PluginServices.h +++ b/fairmq/PluginServices.h @@ -9,7 +9,6 @@ #ifndef FAIR_MQ_PLUGINSERVICES_H #define FAIR_MQ_PLUGINSERVICES_H -#include #include #include #include diff --git a/fairmq/ProgOptions.cxx b/fairmq/ProgOptions.cxx index 15ec4ce0..c795303e 100644 --- a/fairmq/ProgOptions.cxx +++ b/fairmq/ProgOptions.cxx @@ -15,7 +15,7 @@ #include "FairMQLogger.h" #include -#include "tools/Unique.h" +#include #include #include diff --git a/fairmq/ProgOptions.h b/fairmq/ProgOptions.h index dcc002c2..7cbba282 100644 --- a/fairmq/ProgOptions.h +++ b/fairmq/ProgOptions.h @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include diff --git a/fairmq/Transports.h b/fairmq/Transports.h index db6dfcb5..6fe1169e 100644 --- a/fairmq/Transports.h +++ b/fairmq/Transports.h @@ -9,7 +9,7 @@ #ifndef FAIR_MQ_TRANSPORTS_H #define FAIR_MQ_TRANSPORTS_H -#include +#include #include #include diff --git a/fairmq/devices/FairMQBenchmarkSampler.cxx b/fairmq/devices/FairMQBenchmarkSampler.cxx index 255e02cc..cb3e0582 100644 --- a/fairmq/devices/FairMQBenchmarkSampler.cxx +++ b/fairmq/devices/FairMQBenchmarkSampler.cxx @@ -8,10 +8,9 @@ #include "FairMQBenchmarkSampler.h" -#include +#include "tools/RateLimit.h" #include "../FairMQLogger.h" -#include #include using namespace std; @@ -27,10 +26,6 @@ FairMQBenchmarkSampler::FairMQBenchmarkSampler() { } -FairMQBenchmarkSampler::~FairMQBenchmarkSampler() -{ -} - void FairMQBenchmarkSampler::InitTask() { fMultipart = fConfig->GetProperty("multipart"); diff --git a/fairmq/devices/FairMQBenchmarkSampler.h b/fairmq/devices/FairMQBenchmarkSampler.h index b031de71..c48612ba 100644 --- a/fairmq/devices/FairMQBenchmarkSampler.h +++ b/fairmq/devices/FairMQBenchmarkSampler.h @@ -10,8 +10,10 @@ #define FAIRMQBENCHMARKSAMPLER_H_ #include -#include #include +#include // size_t +#include // uint64_t + #include "FairMQDevice.h" @@ -23,7 +25,7 @@ class FairMQBenchmarkSampler : public FairMQDevice { public: FairMQBenchmarkSampler(); - virtual ~FairMQBenchmarkSampler(); + virtual ~FairMQBenchmarkSampler() {} protected: bool fMultipart; diff --git a/fairmq/plugins/DDS/DDS.cxx b/fairmq/plugins/DDS/DDS.cxx index 78db5741..8b4d7166 100644 --- a/fairmq/plugins/DDS/DDS.cxx +++ b/fairmq/plugins/DDS/DDS.cxx @@ -10,19 +10,16 @@ #include -#include +#include #include #include #include #include -#include // for the interactive mode -#include // for the interactive mode -#include -#include #include #include +#include using namespace std; using fair::mq::tools::ToString; @@ -184,7 +181,7 @@ auto DDS::StaticControl() -> void ReleaseDeviceControl(); } catch (exception& e) { ReleaseDeviceControl(); - LOG(error) << "Error: " << e.what() << endl; + LOG(error) << "Error: " << e.what() << "\n"; return; } } @@ -395,7 +392,7 @@ auto DDS::SubscribeForCustomCommands() -> void case Type::dump_config: { stringstream ss; for (const auto pKey: GetPropertyKeys()) { - ss << id << ": " << pKey << " -> " << GetPropertyAsString(pKey) << endl; + ss << id << ": " << pKey << " -> " << GetPropertyAsString(pKey) << "\n"; } Cmds outCmds(make(id, ss.str())); fDDS.Send(outCmds.Serialize(), to_string(senderId)); diff --git a/fairmq/plugins/DDS/DDS.h b/fairmq/plugins/DDS/DDS.h index 1a79aa9f..92feade4 100644 --- a/fairmq/plugins/DDS/DDS.h +++ b/fairmq/plugins/DDS/DDS.h @@ -9,22 +9,24 @@ #ifndef FAIR_MQ_PLUGINS_DDS #define FAIR_MQ_PLUGINS_DDS -#include -#include -#include -#include -#include -#include -#include -#include #include #include #include -#include + +#include +#include + +#include +#include +#include + +#include +#include +#include #include -#include #include #include +#include #include #include #include diff --git a/fairmq/plugins/DDS/runDDSCommandUI.cxx b/fairmq/plugins/DDS/runDDSCommandUI.cxx index 141ad5f8..77009fbc 100644 --- a/fairmq/plugins/DDS/runDDSCommandUI.cxx +++ b/fairmq/plugins/DDS/runDDSCommandUI.cxx @@ -11,21 +11,14 @@ #include -#include -#include -#include -#include #include -#include -#include #include #include -#include #include #include #include -#include // raw mode console input +#include // raw mode console input #include #include #include diff --git a/fairmq/sdk/Error.h b/fairmq/sdk/Error.h index b4cb2eec..3a24188a 100644 --- a/fairmq/sdk/Error.h +++ b/fairmq/sdk/Error.h @@ -9,7 +9,7 @@ #ifndef FAIR_MQ_SDK_ERROR_H #define FAIR_MQ_SDK_ERROR_H -#include +#include #include #include diff --git a/fairmq/sdk/Topology.h b/fairmq/sdk/Topology.h index 4e3bc9c4..ab0839c3 100644 --- a/fairmq/sdk/Topology.h +++ b/fairmq/sdk/Topology.h @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include diff --git a/fairmq/sdk/commands/Commands.h b/fairmq/sdk/commands/Commands.h index 7c9fe919..8c98bb77 100644 --- a/fairmq/sdk/commands/Commands.h +++ b/fairmq/sdk/commands/Commands.h @@ -10,7 +10,7 @@ #define FAIR_MQ_SDK_COMMANDFACTORY #include -#include +#include #include #include diff --git a/fairmq/shmem/Manager.cxx b/fairmq/shmem/Manager.cxx index b2870251..23ddcc6c 100644 --- a/fairmq/shmem/Manager.cxx +++ b/fairmq/shmem/Manager.cxx @@ -8,6 +8,8 @@ #include #include +#include +#include #include #include diff --git a/fairmq/shmem/Manager.h b/fairmq/shmem/Manager.h index 7c068bfc..2547bc0e 100644 --- a/fairmq/shmem/Manager.h +++ b/fairmq/shmem/Manager.h @@ -15,7 +15,6 @@ #ifndef FAIR_MQ_SHMEM_MANAGER_H_ #define FAIR_MQ_SHMEM_MANAGER_H_ -#include #include #include diff --git a/fairmq/shmem/Region.cxx b/fairmq/shmem/Region.cxx index ad5bbf26..395dcf5e 100644 --- a/fairmq/shmem/Region.cxx +++ b/fairmq/shmem/Region.cxx @@ -9,6 +9,8 @@ #include #include #include +#include +#include #include #include diff --git a/fairmq/shmem/Region.h b/fairmq/shmem/Region.h index 1ce9e9a1..924b40fe 100644 --- a/fairmq/shmem/Region.h +++ b/fairmq/shmem/Region.h @@ -18,7 +18,6 @@ #include "FairMQLogger.h" #include "FairMQUnmanagedRegion.h" -#include #include #include diff --git a/fairmq/tools/Strings.h b/fairmq/tools/Strings.h index 11dce092..e2ea0efe 100644 --- a/fairmq/tools/Strings.h +++ b/fairmq/tools/Strings.h @@ -10,7 +10,6 @@ #define FAIR_MQ_TOOLS_STRINGS_H #include -#include #include #include #include @@ -37,16 +36,11 @@ auto ToString(T&&... t) -> std::string /// @brief convert command line arguments from main function to vector of strings inline auto ToStrVector(const int argc, char*const* argv, const bool dropProgramName = true) -> std::vector { - auto res = std::vector{}; - boost::beast::span argvView(argv, argc); - if (dropProgramName) - { - res.assign(argvView.begin() + 1, argvView.end()); - } else - { - res.assign(argvView.begin(), argvView.end()); + if (dropProgramName) { + return std::vector(argv + 1, argv + argc); + } else { + return std::vector(argv, argv + argc); } - return res; } } /* namespace tools */ diff --git a/test/sdk/Fixtures.h b/test/sdk/Fixtures.h index 9085f678..5c8893db 100644 --- a/test/sdk/Fixtures.h +++ b/test/sdk/Fixtures.h @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include