diff --git a/fairmq/Device.cxx b/fairmq/Device.cxx index ac2cc95a..333444c5 100644 --- a/fairmq/Device.cxx +++ b/fairmq/Device.cxx @@ -513,7 +513,8 @@ void Device::HandleMultipleTransportInput() fMultitransportProceed = true; for (const auto& i : fMultitransportInputs) { - threads.emplace_back(thread(&Device::PollForTransport, this, fTransports.at(i.first).get(), i.second)); + threads.emplace_back( + &Device::PollForTransport, this, fTransports.at(i.first).get(), i.second); } for (thread& t : threads) { diff --git a/fairmq/ProgOptions.cxx b/fairmq/ProgOptions.cxx index ba13a8c3..b7da709c 100644 --- a/fairmq/ProgOptions.cxx +++ b/fairmq/ProgOptions.cxx @@ -189,7 +189,7 @@ vector ProgOptions::GetPropertyKeys() const vector keys; for (const auto& it : fVarMap) { - keys.push_back(it.first.c_str()); + keys.emplace_back(it.first.c_str()); } return keys; diff --git a/fairmq/shmem/Manager.h b/fairmq/shmem/Manager.h index eaca8ef2..72de47b8 100644 --- a/fairmq/shmem/Manager.h +++ b/fairmq/shmem/Manager.h @@ -390,7 +390,7 @@ class Manager } auto* lRegion = GetRegion(id); - fTlRegionCache.fRegionsTLCache.emplace_back(std::make_tuple(lRegion, id, fShmId64)); + fTlRegionCache.fRegionsTLCache.emplace_back(lRegion, id, fShmId64); fTlRegionCache.fRegionsTLCacheGen = fRegionsGen; return lRegion; }